Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EOF but no message marker to mark end of message #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

inspiregates
Copy link

No description provided.

@nemith
Copy link
Collaborator

nemith commented May 11, 2023

whats the scenario that triggers this?

@inspiregates
Copy link
Author

inspiregates commented May 11, 2023

whats the scenario that triggers this?

When the SSH connection is terminated by the remote device, sometimes there is an EOF received and sometimes not. When it is not EOF, this is triggered.

In my case, the code starts with listening on an incoming TCP connection (originated by a remote device) on a given port and uses that TCP connection to establish a netconf.DialSSHTimeout() session. When the remote device closes the TCP connection on its own, the netconf session receives either an EOF sometimes (that is handled) or results in an error saying "WaitForFunc Failed", which this fix aids.

@inspiregates inspiregates marked this pull request as ready for review May 12, 2023 20:39
@inspiregates
Copy link
Author

Does this need anymore justification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants