Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scheme ssh in URI constructor #36

Merged
merged 2 commits into from
May 19, 2022
Merged

Allow scheme ssh in URI constructor #36

merged 2 commits into from
May 19, 2022

Conversation

vdayanand
Copy link
Contributor

fixes #35

@quinnj
Copy link
Member

quinnj commented Apr 19, 2022

Thanks @vdayanand! Would you mind adding a test just to ensure it works as expected and things don't accidentally regress in the future?

quinnj
quinnj approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test @fonsp!

@quinnj quinnj merged commit 4f5ff16 into JuliaWeb:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to construct URI if scheme is ssh
3 participants
@vdayanand @quinnj @fonsp