Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to construct URI if scheme is ssh #35

Closed
vdayanand opened this issue Mar 17, 2022 · 2 comments · Fixed by #36
Closed

Unable to construct URI if scheme is ssh #35

vdayanand opened this issue Mar 17, 2022 · 2 comments · Fixed by #36

Comments

@vdayanand
Copy link
Contributor

julia> URIs.URI(scheme = "ssh",  host="test.com", userinfo="testuser" )
ERROR: ArgumentError: backtrace() requires scheme in uses_authority || isempty(host)
Stacktrace:
 [1] macro expansion
   @ ~/.julia/packages/URIs/o9DQG/src/debug.jl:52 [inlined]
 [2] URI(uri::URI; scheme::String, userinfo::SubString{String}, host::String, port::SubString{String}, path::SubString{String}, query::SubString{String}, fragment::SubString{String})
   @ URIs ~/.julia/packages/URIs/o9DQG/src/URIs.jl:70
 [3] #URI#4
   @ ~/.julia/packages/URIs/o9DQG/src/URIs.jl:83 [inlined]
 [4] top-level scope
   @ REPL[17]:1

I see ssh is not present in

const uses_authority = ["https", "http", "ws", "wss", "hdfs", "ftp", "gopher", "nntp", "telnet", "imap", "wais", "file", "mms", "shttp", "snews", "prospero", "rtsp", "rtspu", "rsync", "svn", "svn+ssh", "sftp" ,"nfs", "git", "git+ssh", "ldap", "s3"]

Any reason to exclude ssh?

@quinnj
Copy link
Member

quinnj commented Apr 9, 2022

No reason to exclude; mind making a PR to add?

@fonsp
Copy link
Member

fonsp commented May 19, 2022

More generally #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants