Run thread-safety checks when Julia is using threads #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 35 35
Lines 1743 1743
=======================================
Hits 1658 1658
Misses 85 85 Continue to review full report at Codecov.
|
|
I've subverted the thread-safe cache to validate that these thread-safety tests still fail with this change. |
|
Tests still pass even without the thread-safe cache. I have managed to produce a thread-safety failure locally so I think the best way to proceed is to merge this PR (with the proper thread-safe cache) and hopefully I can get some additional information in regards to #386 |
This reverts commit 325d900.
omus
force-pushed
the
cv/thread-test-investigation
branch
from
005380e
to
325d900
Compare
kpamnany
pushed a commit
to RelationalAI-oss/TimeZones.jl
that referenced
this pull request
May 5, 2023
* Run thread-safety checks when Julia is using threads * Use 8-threads specifically * Reset cache for thread-safety checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digging into #386. Seems like these failures are less random than they first appeared. Running the thread tests in a separate Julia process result in stack traces being lost and only allow for speculative debugging. By enabling threads on the CI and only running the tests when threads are enabled we should be able to get useful information to address the root of the problem.