Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for JuMP 0.20 and StructJuMP#master #25

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

cynddl
Copy link
Contributor

@cynddl cynddl commented Feb 3, 2020

Here's a tentative pull request to make StructDualDynProg pass all tests and work with recent JuMP+StructJuMP. Still using MathProgBase however.

Removed GLPK from solver testing to pass tests while waiting to use MOI.

@blegat
Copy link
Member

blegat commented Feb 3, 2020

The representation we need to communicate with MPB:

c, T, W, h, C, K, _ = StructJuMP.conicconstraintdata(m)

is not provided by StructJuMP anymore. Here the tests are passing because we don't any any solver so the tests are skipped.

@blegat blegat merged commit 24e9a26 into JuliaStochOpt:master Feb 3, 2020
@odow
Copy link
Member

odow commented Feb 3, 2020

Did you mean to merge this? JuMP 0.20 can't work with MathProgBase?

@blegat
Copy link
Member

blegat commented Feb 3, 2020

The master branch of this package is for using the package with MOI/JuMP. This PR made a first step in that direction so I merged. The migration to MOI is mandatory indeed, #26 aims to continue the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants