bug fix jacobian name

JuliaStellarDynamics · Mar 7, 2024 · f55b815 · f55b815
1 parent 13f91dc
commit f55b815
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/OrbitalElements.jl b/src/OrbitalElements.jl
@@ -22,6 +22,7 @@ export rpra_from_ae, ae_from_rpra
 export EL_from_ae, actions_from_ae
 export αβ_from_ae, frequencies_from_ae
 # mappings (jacobians)
+export ae_to_rpra_jacobian, rpra_to_ae_jacobian
 # mappings (backward)
 export ae_from_EL, ae_from_actions
 export ae_from_αβ, ae_from_frequencies

diff --git a/src/mappings/peri_apocentre.jl b/src/mappings/peri_apocentre.jl
@@ -39,7 +39,7 @@ end
 
 Jacobian of the (a,e) ↦ (rp,ra) mapping, i.e. |∂(rp,ra)/∂(a,e)|
 """
-function JacAEToRpRa(a::Float64,e::Float64)::Float64
+function ae_to_rpra_jacobian(a::Float64,e::Float64)::Float64
     _checkdomain_ae(a, e)
     return 2a
 end
diff --git a/test/test_mappings.jl b/test/test_mappings.jl
@@ -4,6 +4,12 @@
 # @IMPROVE list untested stuff
 
 @testset "mappings" begin
+    @testset "model independent" begin
+        a, e = 1.0, 0.5
+        rp, ra = rpra_from_ae(a, e)
+        @test all(rpra_from_ae(1.0, 0.0) .≈ (1.0, 1.0))
+        @test rpra_to_ae_jacobian(rp, ra) * ae_to_rpra_jacobian(a, e) ≈ 1
+    end
     # Compare analytical to numerical results in the isochrone
     anapot = AnalyticIsochrone()
     numpot = NumericalIsochrone()