Clean up tables interface implementation #503
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning for changes:
rowaccess
/rows
because if we definecolumnaccess
/columns
then we automatically get an efficient fallbackrows
definitioncolumnnames
/getcolumn
/schema
onTimeArray
, only on the type thatTables.columns
returns, so in this case, justTableIter
Tables.columns
first and then callTables.schema(cols)
; callingTables.schema
directly on the table input isn't valid, as it wouldn't work in, for example, the case where someone passed in a::TimeArray
.