Skip to content

Commit

Permalink
Remove test for a method from StatsBase (#233)
Browse files Browse the repository at this point in the history
The code is testing that `counts` with two empty input arrays produces
an `ArgumentError`, which is failing because it actually produces a
`MethodError` from a Base function deeper in the call stack. The method
in question here is defined in StatsBase, not in this package, so it's
unclear why this package is testing it to begin with.
  • Loading branch information
ararslan authored Sep 8, 2022
1 parent 01ea380 commit c1938bd
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/counts.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ end

@testset "counts() (contingency matrix)" begin

# StatsBase's counts() doesn't allow empty inputs
@test_throws ArgumentError counts(Int[], Int[])
# Clustering's counts()
@test counts(SimpleCluRes(Int[]), Int[]) == Matrix{Int}(undef, 0, 0)
@test_throws DimensionMismatch counts(SimpleCluRes([1]), Int[])
Expand Down

0 comments on commit c1938bd

Please sign in to comment.