Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add COO constructor and update method #91

Merged
merged 2 commits into from
Apr 21, 2024
Merged

add COO constructor and update method #91

merged 2 commits into from
Apr 21, 2024

Conversation

dpo
Copy link
Member

@dpo dpo commented Apr 21, 2024

The diff makes the change look more complicated than it is. I haven't added SparseMatricesCOO as a dependency; perhaps it's not necessary.

The reason why there are two integer parameters J and I is that size(A) apparently always return Int64s, whereas findnz(A) return integer arrays of type defined by A.

@dpo dpo requested a review from amontoison April 21, 2024 03:41
Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

I propose to not parametrize m and n by T and directly set m::Int and n::Int.
In practrice we don't use other integer type.
We can also set m::Integer and n::Integer.

@dpo dpo force-pushed the coo-constructor branch from ec1011f to a5232ba Compare April 21, 2024 15:37
@dpo
Copy link
Member Author

dpo commented Apr 21, 2024

Done.

@dpo dpo merged commit d78db22 into main Apr 21, 2024
15 of 21 checks passed
@dpo dpo deleted the coo-constructor branch April 21, 2024 16:04
@dpo dpo mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants