New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preallocate references to values for qrm_get in qrm_spfct #115

Merged

amontoison merged 2 commits into JuliaSmoothOptimizers:main from MaxenceGollier:allocs

Jan 22, 2025

Contributor

MaxenceGollier commented Jan 22, 2025

@amontoison In the same spirit as #113, I will eventually need this if I end up using qrm_get as suggested in #114.


          preallocate get value for qrm_get in qrm_spfct

cb5b32b

Member

amontoison commented Jan 22, 2025 •

edited

Loading

You can do less modifications with just val = spfct.ref_int and val = spfct.ref_float.

Can you also add an allocation test?


          add unit tests for qrm_get allocs and minimize changes in wrapper

e1fc075

amontoison approved these changes

View reviewed changes

amontoison merged commit 23c837a into JuliaSmoothOptimizers:main

17 of 23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet