Skip to content

Commit

Permalink
Update Project.toml
Browse files Browse the repository at this point in the history
  • Loading branch information
@amontoison
amontoison authored May 22, 2024
1 parent 65bda82 commit 3054d7c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ DataFrames = "1"
JLD2 = "0.4"
JuMP = "~0.19, ~0.20, ~0.21, ~0.22, 0.23, 1"
Requires = "1"
SpecialFunctions = "1"
SpecialFunctions = "2"
julia = "~1"

[extras]
Expand Down

4 comments on commit 3054d7c

@tmigot
Copy link
Member

@tmigot tmigot commented on 3054d7c May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amontoison Was this in a PR? This is a breaking change + there was another change in the API in a previous commit.

@amontoison
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, SpecialFunctions just changes the function factorial but nothing breaking otherwise.
The other change is to ensure that all problems can be wrapped in an MathOptNLPModel.

When I will support quadratic constraints in NLPModelsJuMP.jl, we can change it with #321.

@tmigot
Copy link
Member

@tmigot tmigot commented on 3054d7c May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but this can still block if for some reason another package (outside JSO) depends on SpecialFunction.
and there was this commit e66bd7e .
Let's see how it goes, and if we plan another release soon maybe we can switch 0.7.4 to a 0.8.0.

@tmigot
Copy link
Member

@tmigot tmigot commented on 3054d7c May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I will support quadratic constraints in NLPModelsJuMP.jl, we can change it with #321.

That would be awesome! It's been very high on the list for quite some time :).

Please sign in to comment.