chore: Limit the number of problems in the longer tests to 5 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 79.75% 79.75%
=======================================
Files 10 10
Lines 242 242
=======================================
Hits 193 193
Misses 49 49 ☔ View full report in Codecov by Sentry. |
tmigot
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM, thanks @abelsiqueira !
I guess if we have a benchmark regularly running that would replace this extensive test.
|
That makes sense. Maybe a more aggressive benchmark CI? Run every time, for instance? |
|
I think it is a good idea for such package |
|
Spawned #146 for benchmark |
|
Thanks for the review. Merging despite docs failure, since they are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #140, but does not close the issue. Tests still take too long.