-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: MinCostFlows v0.1.2 #120355
base: master
Are you sure you want to change the base?
New package: MinCostFlows v0.1.2 #120355
Conversation
JuliaRegistrator
commented
Nov 28, 2024
•
edited
Loading
edited
- Registering package: MinCostFlows
- Repository: https://github.com/NREL/MinCostFlows.jl
- Created by: @GordStephen
- Version: v0.1.2
- Commit: 8f5f907321491b084cb144c0ba94f09a92ea62dd
- Reviewed by: @GordStephen
- Reference: NREL/MinCostFlows.jl@8f5f907#commitcomment-149724029
- Description: Fast min-cost flow solver for network optimization in PRAS
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines which are not met ❌
3. Needs action: here's what to do next
If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the 4. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
UUID: 62286e6e-1779-56f1-888a-1c0056788ce0 Repo: https://github.com/NREL/MinCostFlows.jl.git Tree: 8638ccd186172fbdea29b554dc8495561472fff5 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
8d4ad5e
to
4cc28d3
Compare
Regarding the license: there is indeed a license, but it's "modified" MIT Expat . My understanding is that, at least in 2019 when this software was licensed, it was corporate policy to require that "THE UNITED STATES, THE UNITED STATES DEPARTMENT OF ENERGY, OR ANY OF THEIR EMPLOYEES" be explicitly added to the liability waiver language. Hopefully this isn't a blocker. If it is, I can talk to our tech transfer people about relicensing the software, but if there's any latitude to accept it as-is that would make things a lot easier. [noblock] |
[noblock] My understanding is that there was a decision that an OSI-approved license is a hard requirement. There is no leeway for any kind of modifications beyond what the automated bot still manages to recognize. I wasn't involved in that discussion, but I think the argument was that the Julia community is not equipped to understand what modifications to a license might legally imply. Even if it's a trivial modification such as this one, I'm not sure if there's any registry maintainer who would want to manually override the check somehow. This is especially true because AFAIK the license check is not just performed on the initial registration, but also on all subsequent updates. So, every update of the package would have to be merged manually. Your best bet is probably to use a LICENSE file that makes the bot happy. If it's not possible to sneak in the extra text somehow (the bot does swallow some minor modifications, possibly at the beginning and end, not sure), I would include the extra text in some other place. For example, put the current modified license text at the bottom of your README. I'm not a lawyer, but I don't think the unmodified MIT and your modified MIT are in any way incompatible, or that the note would be any more or less binding if it appeared in the README. Quite honestly, my common-sense legal opinion is that the extra note about the U.S. government is completely redundant. In that vein, you could try to clarify whether that extra language is still necessary. Or, probably better, don't make a fuss about it and find a pragmatic workaround. I suspect you're not going to get into any kind of trouble (even if you were to just completely drop the extra language from the LICENSE), but make your own judgement on that. |
Ok, thanks - that's understandable. I suspect this won't be a big deal to change on our end, but with the holiday here it'll just take a few days to get sorted. [noblock] |