Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: WrapIt v1.1.1 #101684

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Feb 26, 2024

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

UUID: 962878d8-9763-11ee-8c14-fbf60c98afae
Repo: https://github.com/grasph/WrapIt.jl.git
Tree: ae2b6e1f0d680a42c563e841689dd08a0e104a26

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-wrapit-962878d8-v1.1.1-ed6f1d825e branch from 699d97c to 0811bf4 Compare February 26, 2024 11:13
@GunnarFarneback
Copy link
Contributor

[noblock]

To me it looks like the Julia package is a little disconnected from the main functionality by being in its own repository. Are you aware that you can place the Julia package in a subdirectory of the main repository?

If you like the way it's set up now you can just ignore this message. I just wanted to point out the option if you didn't know about it.

@grasph
Copy link

grasph commented Feb 26, 2024

[noblock] Thanks Gunnar for your review and comment. I was not aware of it. It would indeed have been a nice option. Now the repository is set up, it's fine to proceed with a dedicate repository.

@GunnarFarneback
Copy link
Contributor

[noblock]

Then all you need to do is to edit your comment to include [noblock], so you don't block yourself from an automatic merge when the waiting time is up.

@JuliaTagBot JuliaTagBot merged commit 2fa257b into master Feb 29, 2024
11 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-wrapit-962878d8-v1.1.1-ed6f1d825e branch February 29, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants