add 2-arg hash function #1054
Merged
add 2-arg hash function #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 67.75% 67.78% +0.03%
==========================================
Files 20 20
Lines 2025 2024 -1
==========================================
Hits 1372 1372
+ Misses 653 652 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stevengj
reviewed
Sep 20, 2023
src/PyCall.jl
Outdated
| @@ -273,20 +273,20 @@ end | |||
| const pysalt = hash("PyCall.PyObject") # "salt" to mix in to PyObject hashes | |||
| hashsalt(x) = hash(x, pysalt) | |||
There was a problem hiding this comment.
Probably just delete this function (also from src/precompile.jl).
|
LGTM. I agree about removing I can't remember why I did it this way — may be from quite an old Julia version. |
stevengj
reviewed
Sep 20, 2023
|
Thanks! Let me know if there is anything else to be done here. |
stevengj
approved these changes
Sep 20, 2023
|
@stevengj would it be possible to merge this? Thanks! - Miles |
stevengj
reviewed
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On discourse (https://discourse.julialang.org/t/sympy-sym-s-as-keys-in-dicts/103995) the issue of using tuples of symbolic keys let to the realization that the 2 argument form of
hashresolved to a different code path than the 1-argument form. This consolidates the two.If this PR is reasonable, it might also make sense to remove the precompile statement for
hashsaltand thehashsaltfunction.The approach taken in
PythonCallmight provide an alternative. (Base.hash(x::Py, h::UInt) = reinterpret(UInt, Int(pyhash(x))) - 3h)