Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests from Pluto.jl repository #3

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Move some tests from Pluto.jl repository #3

merged 7 commits into from
Feb 7, 2024

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Jan 30, 2024

Matching fonsp/Pluto.jl#2777

After this PR, PlutoDependencyExplorer will load Pluto during the testing process, and run some tests that use Pluto with the current version of PlutoDependencyExplorer loaded. This means that:

  • I don't need to rewrite our existing tests about reactive ordering into more minimal PDD API calls. I just moved stuff from Pluto.jl/test/React.jl.
  • It's integration testing, which can be nice.

The setup is a bit tricky because sometimes you need a specific branch of Pluto.jl to match changes to PDD. For this, there is the test/pluto integration/DEV EDIT ME pluto pkg source.jl file (take a look). But for regular changes, you can just edit files in this repo and run pkg> test. Also the CI will just work.

@fonsp fonsp merged commit f26dc9a into main Feb 7, 2024
3 of 4 checks passed
@fonsp fonsp deleted the tests-from-pluto branch February 7, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant