Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that parsedcode is of type Expr #10

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

JackDevine
Copy link
Contributor

Fixes #8

Sorry for the delay and thanks again for your advice in the linked issue.

src/TopologyUpdate.jl Show resolved Hide resolved
@JackDevine
Copy link
Contributor Author

Thanks for making those changes @fonsp ! Doing a few local tests, I can see that the results are different if you always wrap the expressions.

Do you think that the CI failures on Julia latest are unrelated?

@fonsp fonsp merged commit d1b8b26 into JuliaPluto:main Oct 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen requirement that parsed code is of type Expr
2 participants