Merge pull request #556 from JuliaPlots/sd/fix_ml

fix makielayout

src/dictlike.jl

@@ -60,7 +60,20 @@ function Base.copy(attributes::Attributes)
     result = Attributes()
     for (k, v) in attributes
         # We need to create a new Signal to have a real copy
-        result[k] = Observable{Any}(to_value(v))
+        result[k] = copy(v)
+    end
+    return result
+end
+
+function Base.deepcopy(obs::Observable)
+    return Observable{Any}(to_value(obs))
+end
+
+function Base.deepcopy(attributes::Attributes)
+    result = Attributes()
+    for (k, v) in attributes
+        # We need to create a new Signal to have a real copy
+        result[k] = deepcopy(v)
     end
     return result
 end

src/theming.jl

@@ -105,18 +105,19 @@ const minimal_default = Attributes(
     ),
 )
 
-const _current_default_theme = copy(minimal_default)
+const _current_default_theme = deepcopy(minimal_default)
 
 function current_default_theme(; kw_args...)
     return merge!(Attributes(kw_args), _current_default_theme)
 end
 
 function set_theme!(new_theme::Attributes)
     empty!(_current_default_theme)
-    new_theme = merge!(new_theme, minimal_default)
+    new_theme = merge!(new_theme, deepcopy(minimal_default))
     merge!(_current_default_theme, new_theme)
     return
 end
+
 function set_theme!(;kw_args...)
     set_theme!(Attributes(; kw_args...))
 end

test/ReferenceTests/src/image_download.jl

@@ -26,14 +26,13 @@ function download_refimages(tag=last_major_version())
     images = basedir("refimages")
     isfile(images_tar) && rm(images_tar)
     isdir(images) && rm(images, recursive=true, force=true)
-    Downloads.download(url, images_tar)
+    Base.download(url, images_tar)
     Tar.extract(images_tar, images)
     return images
 end
 
 
 # rm(joinpath(@__DIR__, "refimages"), force=true, recursive=true)
 
-# 
+#
 # using Pkg.TOML
-