Merge pull request #653 from JuliaPlots/timholy-teh/fileiosave

Timholy teh/fileiosave

Project.toml

@@ -1,7 +1,7 @@
 name = "AbstractPlotting"
 uuid = "537997a7-5e4e-5d89-9595-2241ea00577e"
 authors = ["Simon Danisch", "Julius Krumbiegel"]
-version = "0.15.23"
+version = "0.15.24"
 
 [deps]
 Animations = "27a7e980-b3e6-11e9-2bcd-0b925532e340"
@@ -60,7 +60,7 @@ FreeType = "3.0"
 FreeTypeAbstraction = "0.8"
 GeometryBasics = "0.3.5"
 GridLayoutBase = "0.5"
-ImageIO = "0.2, 0.3, 0.4"
+ImageIO = "0.2, 0.3, 0.4, 0.5"
 IntervalSets = "0.3, 0.4, 0.5"
 Isoband = "0.1"
 KernelDensity = "0.5, 0.6"

src/display.jl

@@ -225,7 +225,7 @@ Save a `Scene` with the specified filename and format.
 - `px_per_unit`: The size of one scene unit in `px` when exporting to a bitmap format. This provides a mechanism to export the same scene with higher or lower resolution.
 """
 function FileIO.save(
-        f::FileIO.File, fig::FigureLike;
+        filename, fig::FigureLike;
         resolution = size(get_scene(fig)),
         pt_per_unit = 1.0,
         px_per_unit = 1.0,
@@ -237,7 +237,6 @@ function FileIO.save(
     # But otherwise we could get a filetype :UNKNOWN from a corrupt existing file
     # (from an error during save, e.g.), therefore we don't want to rely on the
     # type readout from an existing file.
-    filename = FileIO.filename(f)
     isfile(filename) && rm(filename)
     # query the filetype only from the file extension
     F = filetype(FileIO.query(filename))

test/ReferenceTests/src/ReferenceTests.jl

@@ -16,7 +16,6 @@ using Downloads
 using Pkg.TOML
 using Statistics
 
-
 basedir(files...) = normpath(joinpath(@__DIR__, "..", files...))
 assetpath(files...) = basedir("assets", files...)
 loadasset(files...) = FileIO.load(assetpath(files...))

test/unit_tests/runtests.jl

@@ -1,3 +1,5 @@
+using AbstractPlotting: volume
+
 @testset "Unit tests" begin
     @testset "#659 Volume errors if data is not a cube" begin
         fig, ax, vplot = volume(1:8, 1:8, 1:10, rand(8, 8, 10))