-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAP_pkg_curlinterface] new package #9999
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
61acae7
[GAP_pkg_curlinterface] new package
fingolfin 3dadc3d
workaround
fingolfin 721f0db
WIP
fingolfin 9b4b486
WIP
fingolfin a79be0d
WIP2
fingolfin 2f691e9
set compat bound
fingolfin 8d5dc9e
Apply suggestions from code review
fingolfin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Note that this script can accept some limited command-line arguments, run | ||
# `julia build_tarballs.jl --help` to see a usage message. | ||
include("../common.jl") | ||
|
||
gap_version = v"400.1400.0" | ||
gap_lib_version = v"400.1400.0" | ||
name = "curlinterface" | ||
upstream_version = "2.4.0" # when you increment this, reset offset to v"0.0.0" | ||
offset = v"0.0.0" # increment this when rebuilding with unchanged upstream_version, e.g. gap_version changes | ||
version = offset_version(upstream_version, offset) | ||
|
||
# Collection of sources required to build libsingular-julia | ||
sources = [ | ||
ArchiveSource("https://github.com/gap-packages/curlInterface/releases/download/v$(upstream_version)/curlInterface-$(upstream_version).tar.gz", | ||
"6f758ad512edf033ba8892875c3216cf111feb5b856909b84889cad89c78a4ff"), | ||
] | ||
|
||
# Bash recipe for building across all platforms | ||
script = raw""" | ||
cd curlInterface* | ||
|
||
./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target} --with-gaproot=${prefix}/lib/gap --with-libcurl=${prefix} | ||
make -j${nproc} | ||
|
||
# copy the loadable module | ||
mkdir -p ${prefix}/lib/gap | ||
cp bin/*/*.so ${prefix}/lib/gap/ | ||
|
||
install_license LICENSE | ||
""" | ||
|
||
name = gap_pkg_name(name) | ||
platforms, dependencies = setup_gap_package(gap_version, gap_lib_version) | ||
|
||
append!(dependencies, [ | ||
Dependency("LibCURL_jll"; compat="7.73,8"), | ||
]) | ||
|
||
# The products that we will ensure are always built | ||
products = [ | ||
FileProduct("lib/gap/curl.so", :curl), | ||
] | ||
|
||
# Build the tarballs, and possibly a `build.jl` as well. | ||
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; | ||
julia_compat="1.6", preferred_gcc_version=v"7") | ||
|
||
# rebuild trigger: 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution was to add this
compat
bound, thanks to @giordano for pointing that out!