-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDAL: New version 2.8.2 #9986
base: master
Are you sure you want to change the base?
PDAL: New version 2.8.2 #9986
Conversation
@evetion Please comment on this PR. Is this useful? Is there anything missing? |
It's certainly useful, thanks for the very quick action! ❤️ I'm only doubting the GDAL bounds, you choose the latest, which might be too new? I'm checking the sonames (this build has libgdal.36.dylib), so 36 = v3.10, and 35 = v3.9 (jll v301.902). This version is not used yet by GDAL.jl, which might lead to package conflicts on common downstream packages (GeoDataFrames, Rasters), so it might be safer to use v301.902 here. @visr what do you think? |
I thought we had fixed this... All the |
I'm not entirely sure here (I've always felt a bit out of my depth on these matters), hence me calling on visr. That said, GDAL typically moves their GDAL_SOVERSION forward by one each minor version. Whether their ABI is actually compatible matters little if we link to a specific version in these builds I guess:
|
Yeah you can also tell they bump the SOVERSION in the minor release here: JuliaBinaryWrappers/GDAL_jll.jl@5eb9df0#diff-0ed6f04e79778dda22f5565f89d1f6e95329a8d15c57c4efa586fbe7b7374bcd. I wasn't aware of this. It doesn't hurt GDAL.jl, but it does break PDAL and the currently 7 other downstream builds, only a few of which set compat for GDAL. |
If this is so, then I'm tempted to disable the current (probably unused?) We should also add a comment to the beginning of GDAL_jll's build recipe. I like reading comments from my past self. |
FWIW not that many packages use GDAL_jll directly, so I would consider 3.10 unused of now. Of the jll packages , only two set compat, so others can be assumed broken. Of direct deps GDAL.jl pins GDAL_jll, and ADRIA and GMT have compats via other packages (GeoDataFrames>ArchGDAL>GDAL, and via PROJ_jll respectively). Pinging @joa-quim to be sure. |
GMT_jll directly sets a GDAL version Yggdrasil/G/GMT/build_tarballs.jl Line 79 in 9583804
I confess that I'm nothing at easy with this version/compat things. And I would like to move to GDAL3.10 soon (was not possible when I looked not long ago). |
@giordano Would it be feasible to yank the current |
Why incompatible? They are two different version builds. And as I mentioned above, I will want to make GMT.jl release that links to GDAL 3.10. GMT links directly to |
They are incompatible because their shared library sonames don't match. If you build PDAL_jll against GDAL_jll 3.9 then you cannot use PDAL_jll with GDAL_jll 3.10. This is "cannot use" in the sense "Julia will not detect it, things will abort with a low-level error message at run time". This isn't supposed to happen. Most packages behave differently. If you e.g. build against OpenSSL 3.0.9, then you can run with OpenSSL 3.0.15 just fine. To tell Julia about this (the fact that the sonames differ) we will need to bump the major version number of GDAL_jll when we re-release it for GDAL 3.10. |
OK, I'm fine with the replacement (re-release). I'm in no hurry to use 3.10 |
I'm fine with merging this PR as is 👍🏻 |
Let's wait a day or two. I'm working on Arrow_jll and GDAL_jll at the moment. |
Closes #9985