Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openfhe_julia_int128] initialize and [openfhe_julia] update #9961

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

ArseniyKholod
Copy link
Contributor

No description provided.

@ArseniyKholod ArseniyKholod changed the title [openfhe_julia_int128] Initialize [openfhe_julia_int128] initialize and [openfhe_julia] update Dec 9, 2024
@ArseniyKholod
Copy link
Contributor Author

ArseniyKholod commented Dec 10, 2024

It looks like, that Apple Clang does not support typeid(__int128) or (typeid(unsigned __int128)),

ld64.lld: error: undefined symbol: typeinfo for unsigned __int128

Full error: https://buildkite.com/julialang/yggdrasil/builds/15407#0193ac81-30e5-45fc-9e20-d60db61071bc/668-984.

When I disable apple platfrom, all other pass. I could not find too much information about this problem. Only bug report: https://developer.apple.com/forums/thread/679290. I have no solution for this now, I am not sure, if there is a way around...

O/openfhe_julia/common.jl Outdated Show resolved Hide resolved
O/openfhe_julia_int128/build_tarballs.jl Outdated Show resolved Hide resolved
@ArseniyKholod ArseniyKholod marked this pull request as draft December 10, 2024 21:43
@ArseniyKholod
Copy link
Contributor Author

I have opened an issue to llvm about the typeinfo for __int128 problem: llvm/llvm-project#119608.
For now, I disable Apple compilations for 128-bit version.

@ArseniyKholod ArseniyKholod marked this pull request as ready for review December 12, 2024 10:20
Comment on lines 43 to 51
# For MacOS additional linker flag is required to link typeid(__int128)
if [[ "$target" == *-apple-darwin* ]]; then
export LDFLAGS="-lc++abi"
fi
export LDFLAGS="-lc++abi"
# For MacOS additional linker flag is required to link typeid(__int128)
if [[ "$target" != *-apple-darwin* ]]; then
export LDFLAGS=""
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArseniyKholod this seems wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I changed it. But I am lost, just exporting LDFLAGS="-lc++abi" solved the issue in openfhe-julia test PR, but here it does not...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is actually fails only on x86_64, but aarch64 is OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I tested only aarch86 in our repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants