-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openfhe_julia_int128] initialize and [openfhe_julia] update #9961
base: master
Are you sure you want to change the base?
[openfhe_julia_int128] initialize and [openfhe_julia] update #9961
Conversation
It looks like, that Apple Clang does not support
Full error: https://buildkite.com/julialang/yggdrasil/builds/15407#0193ac81-30e5-45fc-9e20-d60db61071bc/668-984. When I disable apple platfrom, all other pass. I could not find too much information about this problem. Only bug report: https://developer.apple.com/forums/thread/679290. I have no solution for this now, I am not sure, if there is a way around... |
Co-authored-by: Mosè Giordano <[email protected]>
…Yggdrasil into openfhe_julia_128
I have opened an issue to llvm about the typeinfo for __int128 problem: llvm/llvm-project#119608. |
O/openfhe_julia/common.jl
Outdated
# For MacOS additional linker flag is required to link typeid(__int128) | ||
if [[ "$target" == *-apple-darwin* ]]; then | ||
export LDFLAGS="-lc++abi" | ||
fi | ||
export LDFLAGS="-lc++abi" | ||
# For MacOS additional linker flag is required to link typeid(__int128) | ||
if [[ "$target" != *-apple-darwin* ]]; then | ||
export LDFLAGS="" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArseniyKholod this seems wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I changed it. But I am lost, just exporting LDFLAGS="-lc++abi"
solved the issue in openfhe-julia test PR, but here it does not...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it is actually fails only on x86_64, but aarch64 is OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I tested only aarch86 in our repo
No description provided.