[ZBC2014] New build recipe for ZBC2014 #9884
Conversation
Added build_tarball.jl for Zilany Bruce Carney (2014) auditory-nerve model source code for building library jll for Julia packages to use.
There was a problem hiding this comment.
At a quick glance I don't see any license in https://www.urmc.rochester.edu/MediaLibraries/URMCMedia/labs/carney-lab/codes/Zilany-2014-Code-and-paper.zip, which would mean we aren't allowed to build and redistribute the code.
Replace mkdir and cp steps for library file with install step Co-authored-by: Mosè Giordano <[email protected]>
Replaced empty dependencies array assignment with typed version Co-authored-by: Mosè Giordano <[email protected]>
I have (informal) written consent from the original contributors to release the updated source files (i.e., the files located at https://github.com/guestdaniel/ZBC2014.jl_CSource) under the GPL license. Not sure if it suffices to state something along those lines in the source repo to clarify things, or if an additional level of formalism is needed to make the updated code redistributable? Please advise, and if needed I can consult with the other contributors to resolve! |
There was a problem hiding this comment.
I have (informal) written consent from the original contributors to release the updated source files (i.e., the files located at guestdaniel/ZBC2014.jl_CSource) under the GPL license.
It'd be good to have a written record of that, for example in the README of your repo, quoting verbatim the communication you received from the copyright holder to distribute the code under the terms of the GPL license.
|
@giordano Thanks for your assistance thus far! I think I addressed the issues related to naming; let me know if there's anything else needed there... I'll work on getting a copy of written consent for the license change included in the source-code repo README — currently everything is embedded in a long, winding email chain from a while back, so I will contact everyone again to get a "clean" document to put in the README. May take a while... will ping once that's ready! |
| @@ -0,0 +1,26 @@ | |||
| using BinaryBuilder | |||
|
|
|||
| name = "zbc2014" | |||
There was a problem hiding this comment.
Though the name is sufficiently random, that nobody would likely ever need this for anything more general, zbc2014 still seems like an overly terse name for something very specific (the implementation for a scientific publication in a certain academic field).
| name = "zbc2014" | |
| name = "ZilanyBruceCarney2014" |
Notably, to match https://github.com/guestdaniel/ZilanyBruceCarney2014.jl
There was a problem hiding this comment.
I have no strong preference regarding the name being abbreviated or not. My only hesitation is that I glanced at a few of the other folders in Yggdrasil and did not any other packages using last names. Let me know what is advised here.
|
@giordano I've updated the source repository to include a cleaned up copy of an email chain between the original authors and myself; everyone is okay with licensing the modified code under GNU AGPL. Let me know if any additional steps remain. |
Can you please point me to it? I may be missing it. |
Added build_tarball.jl for Zilany, Bruce, and Carney (2014) auditory-nerve model C source code. The script builds
libzbc2014, a shared library for Julia packages to provide access to the model code.