-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wayland] Bump to build for aarch64-freebsd #10006
base: master
Are you sure you want to change the base?
Conversation
Removing the compat bounds to allow using the latest libffi and expat JLLs fixed the build on aarch64-freebsd, but I see some warnings: ┌ Warning: wayland-scanner has an ELF header OS/ABI value that is not set to FreeBSD (9), this may be an issue at link time Not sure how serious that is. They do seem to be specific to aarch64, there's no warnings on x86-64. |
Ok, I think the warning is a false positive: JuliaPackaging/BinaryBuilder.jl#1344 |
Dependency("Expat_jll"; compat="2.2.10"), | ||
Dependency("Libffi_jll"; compat="~3.2.2"), | ||
Dependency("Expat_jll"), | ||
Dependency("Libffi_jll"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove compat bounds, they're there for a reason: #3024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed that those require bounds... The problem is that only the newer versions of the JLLs have been built for aarch64-freebsd, so if the compat bounds are kept then downstream packages won't be able to support aarch64-freebsd (which would be fine with me given what a PITA rebuilding all the packages is). Is it possible to rebuild JLLs at a specific version? If we could rebuild Expat/Libffi at those versions to get aarch64-freebsd builds then I think everything would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, like in all other PRs, changing compat bounds means that you must change the package number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but my question remains: is it possible to rebuild the JLLs at those compat versions? Because otherwise I don't know how to get Wayland building on aarch64-freebsd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just revert to the old version, and then revert the revert.
No description provided.