Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAP_pkg_caratinterface] new package #10001

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

ExecutableProduct("Normalizer_in_N", :Normalizer_in_N),
ExecutableProduct("Normlin", :Normlin),
ExecutableProduct("Orbit", :Orbit),
ExecutableProduct("Order", :Order),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This apparently results in the error

ERROR: LoadError: `Order` is already defined in Base
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:33
 [2] ExecutableProduct(binnames::Vector{String}, varname::Symbol, dir_path::Nothing)
   @ BinaryBuilderBase /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilderBase/LieLT/src/Products.jl:356
 [3] ExecutableProduct(binnames::Vector{String}, varname::Symbol)
   @ BinaryBuilderBase /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilderBase/LieLT/src/Products.jl:355
 [4] ExecutableProduct(::String, ::Symbol)
   @ BinaryBuilderBase /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilderBase/LieLT/src/Products.jl:364
 [5] top-level scope
   @ /cache/build/yggy-amdci7-0/julialang/yggdrasil/G/GAP_pkg/GAP_pkg_caratinterface/build_tarballs.jl:50
in expression starting at /cache/build/yggy-amdci7-0/julialang/yggdrasil/G/GAP_pkg/GAP_pkg_caratinterface/build_tarballs.jl:50

and indeed we have this in BinaryBuilderBase:

    function ExecutableProduct(binnames::Vector{String}, varname::Symbol, dir_path::Union{AbstractString, Nothing}=nothing)
        if isdefined(Base, varname)
            error("`$(varname)` is already defined in Base")
        end

But why? And is this documented somewhere?

Any pointers, @giordano

(I'll work around it here by renaming, presumably also for Symbol below, it is no big issue; but I still am curious as to why this is an error in the first place)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you can't refer to a variable with the same name as a variable exported by Base (unless you qualify it with the module, but we also export the var), we had issues in the past. But perhaps the check can be refined to limit it to exported symbols.

@fingolfin fingolfin merged commit b92e4f8 into master Dec 17, 2024
6 checks passed
@fingolfin fingolfin deleted the mh/GAP_pkg_caratinterface branch December 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants