-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAP_pkg_caratinterface] new package #10001
Conversation
ExecutableProduct("Normalizer_in_N", :Normalizer_in_N), | ||
ExecutableProduct("Normlin", :Normlin), | ||
ExecutableProduct("Orbit", :Orbit), | ||
ExecutableProduct("Order", :Order), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This apparently results in the error
ERROR: LoadError: `Order` is already defined in Base
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:33
[2] ExecutableProduct(binnames::Vector{String}, varname::Symbol, dir_path::Nothing)
@ BinaryBuilderBase /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilderBase/LieLT/src/Products.jl:356
[3] ExecutableProduct(binnames::Vector{String}, varname::Symbol)
@ BinaryBuilderBase /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilderBase/LieLT/src/Products.jl:355
[4] ExecutableProduct(::String, ::Symbol)
@ BinaryBuilderBase /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilderBase/LieLT/src/Products.jl:364
[5] top-level scope
@ /cache/build/yggy-amdci7-0/julialang/yggdrasil/G/GAP_pkg/GAP_pkg_caratinterface/build_tarballs.jl:50
in expression starting at /cache/build/yggy-amdci7-0/julialang/yggdrasil/G/GAP_pkg/GAP_pkg_caratinterface/build_tarballs.jl:50
and indeed we have this in BinaryBuilderBase:
function ExecutableProduct(binnames::Vector{String}, varname::Symbol, dir_path::Union{AbstractString, Nothing}=nothing)
if isdefined(Base, varname)
error("`$(varname)` is already defined in Base")
end
But why? And is this documented somewhere?
Any pointers, @giordano
(I'll work around it here by renaming, presumably also for Symbol
below, it is no big issue; but I still am curious as to why this is an error in the first place)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you can't refer to a variable with the same name as a variable exported by Base (unless you qualify it with the module, but we also export the var), we had issues in the past. But perhaps the check can be refined to limit it to exported symbols.
No description provided.