Avoid side effects when precompiling find_artifact_dir
#66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an explicit call to
find_artifact_dir()
we were actually fetching lazy artifacts during precompilation, which is typically undesired, besides hitting a bug in Downloads.jl in certain versions of Julia (up to 1.10.4) which causes the download of the artifact to hang. Instead, withBase.precompile
we retain the caching of native code, without causing extra downloads during precompilation.Some benchmarks, same as in #53. Before this PR:
With this PR:
So there's no penalty in using
Base.precompile
. If I remove the forced precompilation entirely:This is slower than with the precompilation call, but not as bad as in #53.
Also, with this PR:
Download happens at
using
-time, not during precompilation, as intended. Note that I'm using Julia 1.10.4, which would also cause the precompilation to last at least 30 seconds because of the Downloads.jl bug.Fix #65.