Introduce outer norms to three stopping criteria #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellertuer
added
the
Ready-for-Review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 78 78
Lines 8284 8289 +5
=======================================
+ Hits 8276 8281 +5
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On manifolds, that have components (
PowerManifolds,ProductManifolds, and soonEuclidean), this PR introduces forStopWhenChangeLessStopWhenGradientChangeLessStopWhenGradientLessthe possibility to specify this outer norm, for example as
outer_norm=1for the 1-norm orouter_norm=∞for the maximum norm.