-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #299
Fix typos #299
Conversation
Follow up to #298. Took a lot longer than I thought (found some nice issues in the spellcheck that kept undoing my progress :-)) but I think it turned out alright. If ever someone wants to do this procedure again, let me know and I can send you the github-spellcheck whitelist I've developed that removes a bunch of false-positive (built up automatically after removing over 9000 false-positives). |
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 77 77
Lines 7084 7084
=======================================
Hits 7066 7066
Misses 18 18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR – thanks for spotting all those and carefully using a tool here!
Sometimes we might have rushed a bit too much concerning the docs – while we did document hopefully most keywords for example – we maybe were not 100% careful.
A few seems also to be a bit of copy paste continuations...
If you want, feel free to also add yourself to
https://github.com/JuliaManifolds/Manopt.jl/blob/master/.zenodo.json
as an „Other” – anyone contributing a function or (at least a few) corrections may add themselves :)
Could you maybe write a forem entry (https://forem.julialang.org) or similar about the spellchecker? I would maybe want to run this on Manifolds or ManifoldsBase as well. |
Sure, I'll try write something up today. I'll also send you the whitelist after so you can (hopefully) avoid many false positives. |
@kellertuer: See here https://forem.julialang.org/danielvandh/efficiently-fixing-typos-in-documentation-1j88. I hope it's clear enough. |
and here is the whitelist (paste it at |
Super detailed, thanks! |
PR created using https://github.com/tbroadley/github-spellcheck-cli.