address review comment

JuliaManifolds · Oct 4, 2024 · f636904 · f636904
1 parent cf59553
commit f636904
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/src/DefaultManifold.jl b/src/DefaultManifold.jl
@@ -76,7 +76,10 @@ for fname in [:get_basis_orthonormal, :get_basis_orthogonal, :get_basis_default]
         return CachedBasis($BT(N), [_euclidean_basis_vector(p, i) for i in eachindex(p)])
     end
     @eval function $fname(::DefaultManifold{ℂ}, p, N::ComplexNumbers)
-        return CachedBasis($BT(N), [_euclidean_basis_vector(p, i) for i in eachindex(p)])
+        return CachedBasis(
+            $BT(N),
+            [_euclidean_basis_vector(p, i, real) for i in eachindex(p)],
+        )
     end
 end
 function get_basis_diagonalizing(M::DefaultManifold, p, B::DiagonalizingOrthonormalBasis)

diff --git a/src/bases.jl b/src/bases.jl
@@ -406,15 +406,17 @@ function _dual_basis(
     return DefaultOrthonormalBasis{𝔽}(TangentSpaceType())
 end
 
-function _euclidean_basis_vector(p::StridedArray, i)
-    X = zero(p)
+# if `p` has complex eltype but you'd like to have real basis vectors,
+# you can pass `real` as a third argument to get that
+function _euclidean_basis_vector(p::StridedArray, i, eltype_transform = identity)
+    X = zeros(eltype_transform(eltype(p)), size(p)...)
     X[i] = 1
     return X
 end
-function _euclidean_basis_vector(p, i)
+function _euclidean_basis_vector(p, i, eltype_transform = identity)
     # when p is for example a SArray
-    X = similar(p)
-    copyto!(X, zero(p))
+    X = similar(p, eltype_transform(eltype(p)))
+    fill!(X, zero(eltype(X)))
     X[i] = 1
     return X
 end

diff --git a/test/default_manifold.jl b/test/default_manifold.jl
@@ -637,7 +637,7 @@ using ManifoldsBaseTestUtils
         p = [1.0im, 2.0im, -1.0im]
         CB = get_basis(MC, p, DefaultOrthonormalBasis(ManifoldsBase.ℂ))
         @test CB.data == [[1.0, 0.0, 0.0], [0.0, 1.0, 0.0], [0.0, 0.0, 1.0]]
-        @test CB.data isa Vector{Vector{ComplexF64}}
+        @test CB.data isa Vector{Vector{Float64}}
         @test ManifoldsBase.coordinate_eltype(MC, p, ManifoldsBase.ℂ) === ComplexF64
         @test ManifoldsBase.coordinate_eltype(MC, p, ManifoldsBase.ℝ) === Float64
         CBR = get_basis(MC, p, DefaultOrthonormalBasis())
@@ -679,7 +679,7 @@ using ManifoldsBaseTestUtils
     end
 
     @testset "scalars" begin
-        M = DefaultManifold()
+        M = ManifoldsBase.DefaultManifold()
         p = 1.0
         X = 2.0
         @test copy(M, p) === p