run ProductManifold tests on CI

JuliaManifolds · Oct 1, 2023 · 898e424 · 898e424
1 parent 75b4826
commit 898e424
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 10 deletions.
diff --git a/src/DefaultManifold.jl b/src/DefaultManifold.jl
@@ -29,6 +29,14 @@ function DefaultManifold(n::Vararg{Int}; field = ℝ, parameter::Symbol = :field
     return DefaultManifold{field,typeof(size)}(size)
 end
 
+function allocation_promotion_function(
+    ::DefaultManifold{ℂ},
+    ::Union{typeof(get_vector),typeof(get_coordinates)},
+    ::Tuple,
+)
+    return complex
+end
+
 change_representer!(M::DefaultManifold, Y, ::EuclideanMetric, p, X) = copyto!(M, Y, p, X)
 
 change_metric!(M::DefaultManifold, Y, ::EuclideanMetric, p, X) = copyto!(M, Y, p, X)

diff --git a/src/ManifoldsBase.jl b/src/ManifoldsBase.jl
@@ -996,7 +996,9 @@ include("PowerManifold.jl")
 function __init__()
     @static if !isdefined(Base, :get_extension)
         @require RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd" begin
-            include("../ext/ManifoldsBaseRecursiveArrayToolsExt.jl")
+            include(
+                "../ext/ManifoldsBaseRecursiveArrayToolsExt/ManifoldsBaseRecursiveArrayToolsExt.jl",
+            )
         end
     end
 end

diff --git a/test/product_manifold.jl b/test/product_manifold.jl
@@ -155,25 +155,25 @@ include("test_sphere.jl")
     end
 
     @testset "Show methods" begin
-        M2 = ProductManifold(M1, M1, M2, M2)
-        @test sprint(show, M2) == "ProductManifold($(M1), $(M1), $(M2), $(M2))"
+        M2p = ProductManifold(M1, M1, M2, M2)
+        @test sprint(show, M2p) == "ProductManifold($(M1), $(M1), $(M2), $(M2))"
         withenv("LINES" => 10, "COLUMNS" => 100) do
             @test sprint(show, "text/plain", ProductManifold(M1)) ==
                   "ProductManifold with 1 submanifold:\n $(M1)"
-            @test sprint(show, "text/plain", M2) ==
+            @test sprint(show, "text/plain", M2p) ==
                   "ProductManifold with 4 submanifolds:\n $(M1)\n $(M1)\n $(M2)\n $(M2)"
             return nothing
         end
         withenv("LINES" => 7, "COLUMNS" => 100) do
-            @test sprint(show, "text/plain", M2) ==
+            @test sprint(show, "text/plain", M2p) ==
                   "ProductManifold with 4 submanifolds:\n $(M1)\n ⋮\n $(M2)"
             return nothing
         end
 
         @test sprint(show, "text/plain", ProductManifold(M, M)) == """
         ProductManifold with 2 submanifolds:
-         ProductManifold(Sphere(2, ℝ), Euclidean(2; field=ℝ))
-         ProductManifold(Sphere(2, ℝ), Euclidean(2; field=ℝ))"""
+         ProductManifold($(M1), $(M2))
+         ProductManifold($(M1), $(M2))"""
     end
 
     @testset "product vector transport" begin
@@ -314,14 +314,14 @@ include("test_sphere.jl")
             M,
             a,
             ArrayPartition([1.0, 0.0, 0.0], [0.0, 0.0]),
-            [1.0, 2.0, 3.0, 4.0, 5.0], # this is one element too long, hence assertion error
+            [1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0], # this is one element too long, hence assertion error
             B,
         )
         @test_throws MethodError get_vector!(
             M,
             a,
-            ArrayPartition([1.0, 0.0, 0.0], [0.0, 0.0]),
-            [1.0, 2.0, 3.0, 4.0],
+            ArrayPartition([1.0, 0.0, 0.0], [0.0 0.0; 0.0 0.0]),
+            [1.0, 2.0, 3.0, 4.0, 5.0, 6.0],
             B, # empty elements yield a submanifold MethodError
         )
     end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -37,5 +37,6 @@ using ManifoldsBase
     include("domain_errors.jl")
     include("vector_transport.jl")
     include("metric.jl")
+    include("product_manifold.jl")
     include("vector_bundle.jl")
 end
diff --git a/test/test_sphere.jl b/test/test_sphere.jl
@@ -9,6 +9,26 @@ TestSphere(N::Int, 𝔽 = ℝ) = TestSphere{N,𝔽}()
 
 ManifoldsBase.representation_size(::TestSphere{N}) where {N} = (N + 1,)
 
+function ManifoldsBase.check_point(M::TestSphere, p; kwargs...)
+    if !isapprox(norm(p), 1.0; kwargs...)
+        return DomainError(
+            norm(p),
+            "The point $(p) does not lie on the $(M) since its norm is not 1.",
+        )
+    end
+    return nothing
+end
+
+function ManifoldsBase.check_vector(M::TestSphere, p, X; kwargs...)
+    if !isapprox(abs(real(dot(p, X))), 0.0; kwargs...)
+        return DomainError(
+            abs(dot(p, X)),
+            "The vector $(X) is not a tangent vector to $(p) on $(M), since it is not orthogonal in the embedding.",
+        )
+    end
+    return nothing
+end
+
 function ManifoldsBase.exp!(M::TestSphere, q, p, X)
     return exp!(M, q, p, X, one(number_eltype(X)))
 end