Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a generic row iterator #179

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Implement a generic row iterator #179

merged 4 commits into from
Aug 21, 2023

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Aug 21, 2023

closes #178

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #179 (23481ab) into master (79539dc) will decrease coverage by 0.02%.
The diff coverage is 97.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   91.40%   91.39%   -0.02%     
==========================================
  Files          28       29       +1     
  Lines         896      941      +45     
==========================================
+ Hits          819      860      +41     
- Misses         77       81       +4     
Files Changed Coverage Δ
src/TableTransforms.jl 100.00% <ø> (ø)
src/tablerows.jl 97.77% <97.77%> (ø)
src/transforms/filter.jl 98.46% <100.00%> (ø)

... and 3 files with indirect coverage changes

@eliascarv eliascarv changed the title [WIP] Implement a generic row iterator Implement a generic row iterator Aug 21, 2023
@eliascarv eliascarv marked this pull request as ready for review August 21, 2023 16:51
@eliascarv eliascarv requested a review from juliohm August 21, 2023 16:53
@juliohm juliohm merged commit cf32f66 into master Aug 21, 2023
7 checks passed
@juliohm juliohm deleted the table-rows branch August 21, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter not working properly with some tables
3 participants