Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query parameter #64

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix query parameter #64

merged 2 commits into from
Sep 26, 2024

Conversation

svilupp
Copy link
Contributor

@svilupp svilupp commented Sep 25, 2024

Fixes #63

  • Fixed a bug in request_body that prevented query argument from being passed to HTTP.jl.
  • Updated completion model in the unit tests suite (ada series has been deprecated).
  • Added warnings to create_edit that it's deprecated by OpenAI. Disabled tests for get_usage_status and create_edit functions, as they cannot be tested via API.

Note the tests would fail on create_edit and get_usage_status, both are NOT supported anymore and need to be removed in the next minor release.

@svilupp
Copy link
Contributor Author

svilupp commented Sep 25, 2024

Could either of you please review, @cpfiffer and @roryl23 ?

EDIT: I did run tests locally, but I cannot access the repo secrets here to run with my key…

@roryl23 roryl23 merged commit 38d6c93 into JuliaML:main Sep 26, 2024
1 of 2 checks passed
@roryl23
Copy link
Collaborator

roryl23 commented Sep 26, 2024

Thanks for jumping on this! I'll remove the deprecated features after work today

@svilupp svilupp deleted the fix-url-query branch September 26, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request_openai removes the query parameter api-version for an AzureProvider
2 participants