Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Stacked_MNIST #230 #231

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

josemanuel22
Copy link

Adding Stacked_MNIST #230

@josemanuel22 josemanuel22 changed the title first commit Adding Stacked_MNIST #230 May 30, 2024
@CarloLucibello
Copy link
Member

Thanks for this PR. You need to include the file in src/MLDatasets.jl. Also needs some tests, a docstring and an entry in the documentation in docs/src/datasets

@josemanuel22
Copy link
Author

I have added the documentation and the tests associated with the new StackedMnist dataset. The tests are failing, showing the following error:

  Got exception outside of a @test
  SystemError: opening file "/home/runner/work/MLDatasets.jl/MLDatasets.jl/test/datasets/vision/stacked_mnist.jl"

I don't understand this, as they passed locally. Other than that, I think the PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants