Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImageNet #146
base: master
Are you sure you want to change the base?
Add ImageNet #146
Changes from 11 commits
7852e48
20be9a6
59afe92
1f4dfaf
dfdeaa5
d2ded7e
4809296
cac14d2
1e850ba
2aa0170
06ad214
3097302
02e966d
9fb811c
4e0e8d4
0daca90
09feb3d
df14fea
c92ae00
8637ebe
944bd83
fe38d43
6af86c6
95b13d9
09d5be4
ae1929d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if all ImageNet images meets the requirement, but note that the actual decomposed result size
size(im)
might not bepreferred_size
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually running into warnings with images smaller than
preferred_size
:do you have experience with this @lorenzoh ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this is that JpegTurbo.jl (or libjpegt-turbo) only supports a very limited range of$M/8$ where $M \in [1, 2, ..., 16]$ . Thus the maximal possible
scale_ratio
: they arescale_ratio
is 2. This is exactly whysize(img) == preferred_size
may not hold in practice.The supported
scale_ratio
permits a faster decoding algorithm (by scaling the coefficients instead of the actual images), this is why we can observe the performance boost here.The perhaps safest (I think) solution is to add a
imresize
after it:The
@suppress_err
macro is a handy tool from https://github.com/JuliaIO/Suppressor.jl to disable this warning message.I don't plan to make this
imresize
happen automatically in JpegTurbo.jl because it would otherwise break people's expectation on "keywordpreferred_size
can make decoding faster"