Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove value in favor of functor interface #163

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Remove value in favor of functor interface #163

merged 2 commits into from
Apr 27, 2023

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Apr 27, 2023

As discussed in #126.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #163 (95740ab) into master (d8c0654) will increase coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   96.34%   96.37%   +0.02%     
==========================================
  Files           8        8              
  Lines         520      524       +4     
==========================================
+ Hits          501      505       +4     
  Misses         19       19              
Impacted Files Coverage Δ
src/traits.jl 100.00% <ø> (ø)
src/losses.jl 100.00% <100.00%> (ø)
src/losses/distance.jl 99.47% <100.00%> (ø)
src/losses/margin.jl 100.00% <100.00%> (ø)
src/losses/other.jl 91.11% <100.00%> (ø)
src/losses/scaled.jl 84.61% <100.00%> (+1.28%) ⬆️
src/losses/weighted.jl 91.30% <100.00%> (+1.83%) ⬆️

@juliohm juliohm merged commit fda1ba3 into master Apr 27, 2023
@juliohm juliohm deleted the value branch April 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants