make Markdown.parse public
#56818
Open
make Markdown.parse public
#56818
+57
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias314
force-pushed
the
m3/markdown-parse
branch
from
e9cef2e to
57f4425
Compare
fredrikekre
reviewed
Dec 13, 2024
| @@ -420,6 +420,10 @@ custom flavour of Markdown can be used, but this should generally be unnecessary | |||
| Markdown.MD | |||
| Markdown.@md_str | |||
| Markdown.@doc_str | |||
| Markdown.common | |||
| Markdown.github | |||
There was a problem hiding this comment.
I wonder how well supported this is -- I believe there have been quite many changes to Githubs flavor but no changes to the parser here. cc @mortenpi
There was a problem hiding this comment.
Honestly, I didn't even know there were flavor options for the parser. Maybe we could try to remove the option to customize this and see if anything breaks in the ecosystem? I.e. only allow the Julia flavor going forward, which I think is the only currently documented option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been discussed on Discourse.
I've split the PR into 3 commits:
parsepublic and documenting the public methods,_parse,This way you can more easily decide what to take and what not.