Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export opaque closure constructor #56808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Export opaque closure constructor #56808

wants to merge 1 commit into from
+1 −1

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Dec 12, 2024

No description provided.

@wsmoses wsmoses added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Dec 12, 2024
topolarity
topolarity reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an entry in jl_exported_funcs.inc too, right?
(it looks like jl_new_opaque_closure_from_code_info is also missing from there)

@topolarity topolarity requested a review from Keno December 12, 2024 13:51
vtjnash
vtjnash requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external API is Expr(:new_opaque_closure). This function is private

This was referenced Dec 13, 2024
Open
Open
@wsmoses
Copy link
Contributor Author

wsmoses commented Dec 14, 2024

So there was a expression lexing? error with the expression form I mentioned to keno on slack that I had run into. But in any case fair enough, closng (and will make an alternate solution).

@wsmoses wsmoses removed backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Dec 14, 2024
@wsmoses wsmoses mentioned this pull request Dec 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topolarity topolarity topolarity left review comments

@vtjnash vtjnash vtjnash requested changes

@Keno Keno Awaiting requested review from Keno

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsmoses @vtjnash @topolarity