Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: update enums from v1.8.0 #56764

Merged
merged 7 commits into from
Dec 10, 2024
Merged

libgit2: update enums from v1.8.0 #56764

merged 7 commits into from
Dec 10, 2024

Conversation

inkydragon
Copy link
Member

No description provided.

@inkydragon inkydragon added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Dec 6, 2024
inkydragon
inkydragon commented Dec 6, 2024
View reviewed changes
Copy link
Member Author

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdlib/LibGit2/src/error.jl
@@ -27,14 +27,23 @@ export GitError
EAPPLIED = Cint(-18), # patch/merge has already been applied
EPEEL = Cint(-19), # the requested peel operation is not possible
EEOF = Cint(-20), # unexpected EOF
EINVALID = Cint(-21), # Invalid operation or input
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giordano giordano added the libgit2 The libgit2 library or the LibGit2 stdlib module label Dec 6, 2024
@IanButterworth
Copy link
Member

IanButterworth commented Dec 9, 2024 •
edited
Loading

Does this fix this issue in #56786 ?
https://buildkite.com/julialang/julia-master/builds/42893#0193accf-efd5-487b-9361-7c9152790fcd

  | 2024-12-09 14:47:52 EST | Pkg             (2) \|         failed at 2024-12-09T19:47:52.424
  | 2024-12-09 14:47:52 EST | Error During Test at /cache/build/tester-demeter6-10/julialang/julia-master/julia-e82f30c685/share/julia/stdlib/v1.12/Pkg/test/sources.jl:8
  | 2024-12-09 14:47:52 EST | Got exception outside of a @test
  | 2024-12-09 14:47:52 EST | ArgumentError: invalid value for Enum Code: -30848
  | 2024-12-09 14:47:52 EST | Stacktrace:
  | 2024-12-09 14:47:52 EST | [1] enum_argument_error(typename::Symbol, x::Int32)
  | 2024-12-09 14:47:52 EST | @ Base.Enums ./Enums.jl:93
  | 2024-12-09 14:47:52 EST | [2] Code
  | 2024-12-09 14:47:52 EST | @ ./Enums.jl:212 [inlined]
  | 2024-12-09 14:47:52 EST | [3] LibGit2.Error.GitError(err_code::Int32)
  | 2024-12-09 14:47:52 EST | @ LibGit2.Error /cache/build/tester-demeter6-10/julialang/julia-master/julia-e82f30c685/share/julia/stdlib/v1.12/LibGit2/src/error.jl:103
  | 2024-12-09 14:47:52 EST | [4] macro expansion
  | 2024-12-09 14:47:52 EST | @ /cache/build/tester-demeter6-10/julialang/julia-master/julia-e82f30c685/share/julia/stdlib/v1.12/LibGit2/src/error.jl:115 [inlined]
  | 2024-12-09 14:47:52 EST | [5] clone(repo_url::SubString{String}, repo_path::String, clone_opts::LibGit2.CloneOptions)
  | 2024-12-09 14:47:52 EST | @ LibGit2 /cache/build/tester-demeter6-10/julialang/julia-master/julia-e82f30c685/share/julia/stdlib/v1.12/LibGit2/src/repository.jl:470

@vtjnash
Copy link
Member

vtjnash commented Dec 9, 2024

That is an mbedtls error / error code

@inkydragon
Copy link
Member Author

Does this fix this issue in #56786 ?

No, That's another issue: #56763, maybe it's an upstream issue.

@KristofferC KristofferC merged commit da43f11 into JuliaLang:master Dec 10, 2024
5 of 7 checks passed
@inkydragon inkydragon deleted the cyhan/libgit2-header branch December 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inkydragon @IanButterworth @vtjnash @giordano @KristofferC