Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate_precompile statement grouping & avoid defining new func #56317

Merged

Conversation

IanButterworth
Copy link
Member

Fixes #56227 (comment)

Also, I don't think these are supposed to be inside the for loop which is specific to match (which only runs once anyway).

@IanButterworth
Copy link
Member Author

This still has issues

% ./julia --trace-compile=stderr --startup-file=no -e "@time @eval Base.Experimental.@force_compile"
precompile(Tuple{typeof(Core.kwcall), NamedTuple{(:msg,), Tuple{Nothing}}, typeof(Base.time_print), Base.TTY, Float64, Int64, Int64, Int64, Int64, Float64, Float64, Bool})
  0.000424 seconds (130 allocations: 5.906 KiB, 83.05% compilation time: 100% of which was recompilation)
julia> @time @eval Base.Experimental.@force_compile
precompile(Tuple{Base.Returns{Symbol}, Any})
precompile(Tuple{typeof(Base.indexed_iterate), Tuple{Base.GenericIOBuffer{Memory{UInt8}}, Bool, Bool}, Int64})
precompile(Tuple{typeof(Base.indexed_iterate), Tuple{Base.GenericIOBuffer{Memory{UInt8}}, Bool, Bool}, Int64, Int64}) # recompile
precompile(Tuple{typeof(Base.put!), Base.Channel{Any}, Tuple{Expr, Int64}})
precompile(Tuple{typeof(Base.all), Function, Tuple{Module, Module}})
precompile(Tuple{typeof(Base.first), Tuple{Module, Module}})
precompile(Tuple{typeof(Base.last), Tuple{Module, Module}})
precompile(Tuple{typeof(Base.which), Module, Symbol})
precompile(Tuple{typeof(Base.getindex), Base.RefValue{Ptr{UInt8}}}) # recompile
precompile(Tuple{typeof(Base.cconvert), Type{Ptr{UInt8}}, Ptr{UInt8}}) # recompile
precompile(Tuple{typeof(Base.getindex), Base.RefValue{Int32}}) # recompile
precompile(Tuple{typeof(Base.unsafe_convert), Type{Ptr{UInt8}}, Ptr{UInt8}}) # recompile
precompile(Tuple{typeof(Base.unsafe_convert), Type{Ptr{Ptr{UInt8}}}, Base.RefValue{Ptr{UInt8}}}) # recompile
precompile(Tuple{typeof(Base.unsafe_convert), Type{Ptr{Int32}}, Base.RefValue{Int32}}) # recompile
precompile(Tuple{typeof(Core.kwcall), NamedTuple{(:msg,), Tuple{Nothing}}, typeof(Base.time_print), Base.TTY, Float64, Int64, Int64, Int64, Int64, Float64, Float64, Bool})
  0.000096 seconds (130 allocations: 5.906 KiB, 19.75% compilation time)

@giordano giordano added the backport 1.11 Change should be backported to release-1.11 label Nov 1, 2024
@KristofferC KristofferC mentioned this pull request Nov 22, 2024
34 tasks
@KristofferC KristofferC mentioned this pull request Dec 3, 2024
51 tasks
@KristofferC KristofferC added this to the 1.12 milestone Dec 10, 2024
@vtjnash vtjnash force-pushed the ib/sysimage_precompile_fix branch from 3235e6f to 7dc6683 Compare December 11, 2024 18:02
@IanButterworth IanButterworth merged commit 582585b into JuliaLang:master Dec 11, 2024
7 checks passed
@IanButterworth IanButterworth deleted the ib/sysimage_precompile_fix branch December 12, 2024 02:49
KristofferC pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.11 Change should be backported to release-1.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants