doc: MathConstants: add admonitions noting unknown rationality #55897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
docs
devmotion
added a commit
to JuliaMath/IrrationalConstants.jl
that referenced
this pull request
Sep 27, 2024
* readme: note that some constants are not known to be irrational xref JuliaLang/julia#55897 * rationality -> irrationality Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: David Widmann <[email protected]>
|
bump |
|
ping |
nsajko
force-pushed
the
doc_irrational_euler_catalan
branch
from
dc6f851 to
e5efa0b
Compare
|
bump |
Some of the `Irrational` constants are not known to be irrational, so it'd be good to note that in the doc string of each such constant to avoid being misleading.
nsajko
force-pushed
the
doc_irrational_euler_catalan
branch
from
e5efa0b to
5219773
Compare
|
The failing test is unrelated, xref #56748. |
|
This doesn't seem worth the extra text in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
Irrationalconstants are not known to be irrational, so it'd be good to note that in the doc string of each such constant to avoid being misleading.