Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland " Avoid materializing arrays in bidiag matmul #55450" #55777

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Reland " Avoid materializing arrays in bidiag matmul #55450" #55777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eb68dd5
Avoid materializing arrays in bidiag matmul
jishnub Aug 10, 2024
632f41b
Make iteration cache-friendly in Bidiagonal matmul
jishnub Aug 10, 2024
3f83272
Specialize Bidiagonal * AbstractVecOrMat
jishnub Aug 10, 2024
6136952
Fix field access
jishnub Aug 11, 2024
149b84c
Split bibimul into cases
jishnub Aug 11, 2024
580500e
Fix undef variables in __bibimul
jishnub Aug 11, 2024
b8d8a62
_diag for SymTridiagonal
jishnub Aug 11, 2024
898c390
Column-major iteration in bibimul
jishnub Aug 12, 2024
b54d60e
Tests for a matrix-valued eltype
jishnub Aug 12, 2024
07b5987
Fast path for zero alpha
jishnub Sep 15, 2024
df9fe68
Add more test combinations
jishnub Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/LinearAlgebra/src/LinearAlgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,9 @@ matprod_dest(A::Diagonal, B::Diagonal, TS) = _matprod_dest_diag(B, TS)
_matprod_dest_diag(A, TS) = similar(A, TS)
function _matprod_dest_diag(A::SymTridiagonal, TS)
n = size(A, 1)
Tridiagonal(similar(A, TS, n-1), similar(A, TS, n), similar(A, TS, n-1))
ev = similar(A, TS, max(0, n-1))
dv = similar(A, TS, n)
Tridiagonal(ev, dv, similar(ev))
end

# Special handling for adj/trans vec
Expand Down
Loading