Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Base.donotdelete public #55774

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

LilithHafner
Copy link
Member

I rely on Base.donotdelete in Chairmarks.jl and I'd like it to be public. I imagine that other benchmarking tools also rely on it. It's been around since 1.8 (see also: #55773) and I think we should commit to keeping it functional for the rest of 1.x.

@LilithHafner LilithHafner added the design Design of APIs or of the language itself label Sep 14, 2024
@nsajko
Copy link
Contributor

nsajko commented Sep 14, 2024

donotdelete is actually defined in Core, and it's a built-in, as opposed to a generic function. As far as I understand exposing non-generic functions isn't a good practice. Perhaps it'd make sense to define something like this in Base, and make that public:

function donotdelete(args...)
    Core.donotdelete(args)
end

@nsajko nsajko added feature Indicates new feature / enhancement requests needs news A NEWS entry is required for this change labels Sep 14, 2024
@LilithHafner LilithHafner removed the needs news A NEWS entry is required for this change label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design of APIs or of the language itself feature Indicates new feature / enhancement requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants