Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external IO loop thead interaction and add function to Base.Experimental to facilitate it's use. Also add a test. #55529

Merged
merged 10 commits into from
Nov 7, 2024
Merged

Fix external IO loop thead interaction and add function to Base.Experimental to facilitate it's use. Also add a test. #55529

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ea9d1c2
Fix external IO loop thead interaction and add function to Base.Exper…
gbaraldi Aug 19, 2024
26a234f
Initialize task lock in adopt thread
gbaraldi Aug 19, 2024
f107c6b
Make test GC safe
gbaraldi Aug 20, 2024
4b4bf13
Merge branch 'master' into gb/io-loop-thread
gbaraldi Aug 30, 2024
05384ce
Initialize world counter in adopted threads root task
gbaraldi Aug 30, 2024
0fbc8f2
Merge branch 'master' into gb/io-loop-thread
gbaraldi Sep 9, 2024
f9e99b5
Increase timeout of test to 10 seconds
gbaraldi Sep 16, 2024
7c9b573
Merge branch 'master' into gb/io-loop-thread
gbaraldi Oct 15, 2024
9765da8
Apply suggestions from code review
gbaraldi Oct 15, 2024
16dda97
Merge branch 'master' into gb/io-loop-thread
gbaraldi Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/threading.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ JL_DLLEXPORT jl_gcframe_t **jl_adopt_thread(void)
JL_GC_PROMISE_ROOTED(ct);
uv_random(NULL, NULL, &ct->rngState, sizeof(ct->rngState), 0, NULL);
jl_atomic_fetch_add(&jl_gc_disable_counter, -1);
ct->world_age = jl_get_world_counter(); // root_task sets world_age to 1
vtjnash marked this conversation as resolved.
Show resolved Hide resolved
jl_init_task_lock(ct);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed for all adopted threads? Could we lazy initialize it when somebody tries to wait for the task instead?

return &ct->gcstack;
}
Expand Down