Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos [nfc] #51709

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix typos [nfc] #51709

merged 4 commits into from
Oct 16, 2023

Conversation

LilithHafner
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member

Nice!

@LilithHafner LilithHafner mentioned this pull request Oct 14, 2023
Closed
@LilithHafner LilithHafner mentioned this pull request Oct 14, 2023
Merged
3 tasks
@DilumAluthge DilumAluthge self-requested a review October 14, 2023 20:13
@LilithHafner LilithHafner mentioned this pull request Oct 14, 2023
Closed
DilumAluthge
DilumAluthge reviewed Oct 14, 2023
View reviewed changes
src/julia_internal.h Outdated Show resolved Hide resolved
@DilumAluthge DilumAluthge self-requested a review October 14, 2023 20:39
@DilumAluthge DilumAluthge self-requested a review October 14, 2023 21:22
@LilithHafner
Copy link
Member Author

Force-push was undoing an accidental push that was meant for #51704

@nsajko

This comment was marked as resolved.

Sign in to view
@LilithHafner
Copy link
Member Author

I'm going to merge this soon unless someone objects. I don't want to deal with merge conflicts and this touches 70 files.

@DilumAluthge
Copy link
Member

I'll go through and do one last full pass now.

DilumAluthge
DilumAluthge reviewed Oct 16, 2023
View reviewed changes
doc/src/devdocs/pkgimg.md Show resolved Hide resolved
stdlib/REPL/test/replcompletions.jl
@@ -1980,7 +1980,7 @@ let (c, r, res) = test_complete_context("getkeyelem(mutable_const_prop).value.")
end

# JuliaLang/julia/#51548
# don't return wrong result due to mutable inconsistentcy
# don't return wrong result due to mutable inconsistency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simeonschaub @aviatesk

Does this refer to the :consistent effect? If so, should this say "don't return wrong result due to mutable in-:consistent-cy", or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does refer to the effect, but IMHO it's fine to refer to the effect like this. Spelling it consistent-cy always reads a bit clunky to me

DilumAluthge
DilumAluthge approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If we do end up needing to fix anything regarding the inconsistentcy => inconsistency change (stdlib/REPL/test/replcompletions.jl line 1983), we can do so in a follow-up PR.

@DilumAluthge
Copy link
Member

@LilithHafner Can you add exhasutive => exhaustive to the list of new typos that you've reported to typos?

@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Oct 16, 2023
@LilithHafner
Copy link
Member Author

Already have: crate-ci/typos#843 (comment)

@LilithHafner LilithHafner merged commit 0c4af32 into master Oct 16, 2023
2 checks passed
@LilithHafner LilithHafner deleted the lh/fix-typos branch October 16, 2023 01:34
@LilithHafner LilithHafner removed the merge me PR is reviewed. Merge when all tests are passing label Oct 16, 2023
@LilithHafner LilithHafner restored the lh/fix-typos branch October 16, 2023 18:47
@LilithHafner LilithHafner deleted the lh/fix-typos branch October 16, 2023 19:04
@LilithHafner LilithHafner restored the lh/fix-typos branch October 16, 2023 22:28
@ViralBShah ViralBShah deleted the lh/fix-typos branch October 16, 2023 22:42
@LilithHafner LilithHafner mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub left review comments

@ViralBShah ViralBShah ViralBShah left review comments

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LilithHafner @DilumAluthge @nsajko @ViralBShah @simeonschaub