Skip to content

Commit

Permalink
Try to put back previously flakey addmul tests
Browse files Browse the repository at this point in the history
  • Loading branch information
LilithHafner committed Sep 14, 2024
1 parent 346f38b commit 4a6ca44
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions stdlib/LinearAlgebra/test/addmul.jl
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ for cmat in mattypes,
push!(testdata, (cmat{celt}, amat{aelt}, bmat{belt}))
end

for _ in 1:100 # TODO: delete this line
@testset "mul!(::$TC, ::$TA, ::$TB, α, β)" for (TC, TA, TB) in testdata
if needsquare(TA)
na1 = na2 = rand(sizecandidates)
Expand Down Expand Up @@ -164,8 +165,7 @@ end
Bc = Matrix(B)
returned_mat = mul!(C, A, B, α, β)
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol
@test collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol

y = C[:, 1]
x = B[:, 1]
Expand All @@ -190,8 +190,7 @@ end

returned_mat = mul!(C, Af, Bf, α, β)
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol
@test collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol
end
end
end
Expand All @@ -203,8 +202,7 @@ end
Bc = Matrix(B)
returned_mat = mul!(C, A, B, α, zero(eltype(C)))
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) α * Ac * Bc rtol=rtol
@test collect(returned_mat) α * Ac * Bc rtol=rtol
end
end

Expand All @@ -219,5 +217,6 @@ end
end
end
end
end # TODO: delete this line

end # module

0 comments on commit 4a6ca44

Please sign in to comment.