Skip to content

Commit

Permalink
remove new references to explicit_loaded_modules
Browse files Browse the repository at this point in the history
  • Loading branch information
KristofferC committed Oct 21, 2024
1 parent ad1dc39 commit 319ee70
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions base/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2517,9 +2517,6 @@ loaded_modules_array() = @lock require_lock copy(loaded_modules_order)
# after unreference_module, a subsequent require call will try to load a new copy of it, if stale
# reload(m) = (unreference_module(m); require(m))
function unreference_module(key::PkgId)
if haskey(explicit_loaded_modules, key)
m = pop!(explicit_loaded_modules, key)
end
if haskey(loaded_modules, key)
m = pop!(loaded_modules, key)
# need to ensure all modules are GC rooted; will still be referenced
Expand Down Expand Up @@ -3125,7 +3122,7 @@ function compilecache(pkg::PkgId, path::String, internal_stderr::IO = stderr, in
# build up the list of modules that we want the precompile process to preserve
if keep_loaded_modules
concrete_deps = copy(_concrete_dependencies)
for (pkgreq, modreq) in loaded_modules # TODO: convert all relevant staleness heuristics to use explicit_loaded_modules instead
for (pkgreq, modreq) in loaded_modules
if !(pkgreq === Main || pkgreq === Core || pkgreq === Base)
push!(concrete_deps, pkgreq => module_build_id(modreq))
end
Expand Down

0 comments on commit 319ee70

Please sign in to comment.