Add import_to_main flag for Main module package name conflicts resolution
#807
Conversation
| for pkg in packages | ||
| print(julia_code_buffer, """ | ||
| if isdefined(Main, Symbol("$pkg")) | ||
| @warn( |
There was a problem hiding this comment.
Did you check that users will see this warning?
There was a problem hiding this comment.
I saw it on a build once but let me confirm on a simple example
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 3 3
Lines 827 827
=======================================
Hits 700 700
Misses 127 127 ☔ View full report in Codecov by Sentry. |
|
@KristofferC Can we merge and tag this? I confirmed it works fine on my case |
src/PackageCompiler.jl
Outdated
| @@ -504,6 +516,9 @@ compiler (can also include extra arguments to the compiler, like `-g`). | |||
| transitive dependencies into the sysimage. This only makes a difference if some | |||
| packages do not load all their dependencies when themselves are loaded. Defaults to `true`. | |||
|
|
|||
| - `import_into_main::Bool`: If `true`, import all packages from the sysimage into `Main`. | |||
There was a problem hiding this comment.
Is this true? I thought it was just the packages in the [deps] section of the project file.
There was a problem hiding this comment.
No, I believe only deps from the project you're creating a sysimage of go in
| - `import_into_main::Bool`: If `true`, import all packages from the sysimage into `Main`. | |
| - `import_into_main::Bool`: If `true`, import all packages from `packages` into `Main`. |
This is more accurate I guess
This contains only the
import_to_mainpart of #794Fixes #768
Changelog:
import_into_mainflag (default true), which allows you to control whether the top level packages will be imported into Main in the sysimage