-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of test combinations in test/triangular.jl #1123
base: master
Are you sure you want to change the base?
Conversation
@KristofferC Btw. I wanted to run some timings locally on my mac but the system image build hadn't finished after two hours so I interrupted it. Any idea why it would take so long? I used current release of Julia and the latest version of |
Possibly related to JuliaLang/PackageCompiler.jl#990. So make sure that is not set. |
Thanks. Indeed that was the issue. Now I can build a new system image but I'm hitting julia> S = SizedArrays.SizedArray{(3,3)}(reshape(1:9,3,3))
3×3 Main.SizedArrays.SizedArray{(3, 3), Int64, 2, Base.ReshapedArray{Int64, 2, UnitRange{Int64}, Tuple{}}} with indices SOneTo(3)×SOneTo(3):
1 4 7
2 5 8
3 6 9
julia> convert(AbstractMatrix{Float64}, S)
ERROR: MethodError: no method matching similar(::Main.SizedArrays.SizedArray{…}, ::Type{…}, ::Tuple{…})
The function `similar` exists, but no method is defined for this combination of argument types.
Closest candidates are:
similar(::Base.Broadcast.Broadcasted{Base.Broadcast.ArrayConflict}, ::Type{ElType}, ::Any) where ElType
@ Base broadcast.jl:229
similar(::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{N}}, ::Type{ElType}, ::Any) where {N, ElType}
@ Base broadcast.jl:224
similar(::AbstractArray, ::Type{T}, ::NTuple{N, Int64}) where {T, N}
@ Base abstractarray.jl:833 when running with Julia 1.11. Is that known Update: can see that this is not an issue on nightly. |
This PR is against the one with O0. Is that intended? |
9bea35a
to
468814f
Compare
I updated this to only have the eltype change so we can see the effect. |
I started with the run. It's here https://buildkite.com/julialang/linearalgebra-dot-jl/builds/45#01936fb4-b7f2-44f7-bc1e-dd6696b8fcce and then moved the target to see the combined effect which is https://buildkite.com/julialang/linearalgebra-dot-jl/builds/46#019371c1-e511-480a-b72c-150fee510177. It looks like the |
Currently, we are most likely testing more cases of mixed element types than needed. See #1117. This PR reduces the mixed cases to
(Int, Float32)
and(Float32, Int)
to get an idea how much of a difference it makes for the CI time.