Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of test combinations in test/triangular.jl #1123

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andreasnoack
Copy link
Member

Currently, we are most likely testing more cases of mixed element types than needed. See #1117. This PR reduces the mixed cases to (Int, Float32) and (Float32, Int) to get an idea how much of a difference it makes for the CI time.

@andreasnoack
Copy link
Member Author

@KristofferC Btw. I wanted to run some timings locally on my mac but the system image build hadn't finished after two hours so I interrupted it. Any idea why it would take so long? I used current release of Julia and the latest version of PackageCompiler

@KristofferC
Copy link
Member

KristofferC commented Nov 27, 2024

Possibly related to JuliaLang/PackageCompiler.jl#990. So make sure that is not set.

@andreasnoack andreasnoack changed the base branch from master to andreasnoack-patch-1 November 28, 2024 07:51
@andreasnoack andreasnoack reopened this Nov 28, 2024
@andreasnoack
Copy link
Member Author

andreasnoack commented Nov 28, 2024

Thanks. Indeed that was the issue. Now I can build a new system image but I'm hitting

julia> S = SizedArrays.SizedArray{(3,3)}(reshape(1:9,3,3))
3×3 Main.SizedArrays.SizedArray{(3, 3), Int64, 2, Base.ReshapedArray{Int64, 2, UnitRange{Int64}, Tuple{}}} with indices SOneTo(3)×SOneTo(3):
 1  4  7
 2  5  8
 3  6  9

julia> convert(AbstractMatrix{Float64}, S)
ERROR: MethodError: no method matching similar(::Main.SizedArrays.SizedArray{…}, ::Type{…}, ::Tuple{…})
The function `similar` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  similar(::Base.Broadcast.Broadcasted{Base.Broadcast.ArrayConflict}, ::Type{ElType}, ::Any) where ElType
   @ Base broadcast.jl:229
  similar(::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{N}}, ::Type{ElType}, ::Any) where {N, ElType}
   @ Base broadcast.jl:224
  similar(::AbstractArray, ::Type{T}, ::NTuple{N, Int64}) where {T, N}
   @ Base abstractarray.jl:833

when running with Julia 1.11. Is that known and the reason why you set up testing with 1.10 in this repo (was confused by this)?

Update: can see that this is not an issue on nightly.

@KristofferC
Copy link
Member

This PR is against the one with O0. Is that intended?

@KristofferC KristofferC changed the base branch from andreasnoack-patch-1 to master November 28, 2024 12:23
@KristofferC
Copy link
Member

I updated this to only have the eltype change so we can see the effect.

@andreasnoack
Copy link
Member Author

andreasnoack commented Nov 28, 2024

I started with the run. It's here https://buildkite.com/julialang/linearalgebra-dot-jl/builds/45#01936fb4-b7f2-44f7-bc1e-dd6696b8fcce and then moved the target to see the combined effect which is https://buildkite.com/julialang/linearalgebra-dot-jl/builds/46#019371c1-e511-480a-b72c-150fee510177. It looks like the -O0 benefits almost all, if not all, the test groups so I think we should move forward with both of these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants