Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Improved tab completion for symbols #634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpastell
Copy link
Contributor

@mpastell mpastell commented Mar 3, 2018

This implements improved (IMHO) tab completion for latex symbols and emojis. It completes the list of symbols and names starting with that symbol as well. Is this something that others see as a preferable behavior as well? I have only tested it in Jupyterlab with Julia 0.6 so far.

complete_symbols

@stevengj
Copy link
Member

stevengj commented Mar 3, 2018

This is the kind of patch that should go directly into the REPLCompletions stdlib package, I think.

@mpastell
Copy link
Contributor Author

mpastell commented Mar 3, 2018

I think the REPL user experience would be quite poor this patch. In Jupyter you can choose the completions from a menu where as in the REPL you need to type the rest of the characters.

Also the emojis and some of the latex symbols only show as question marks in the REPL.

@stevengj
Copy link
Member

stevengj commented Mar 3, 2018

Also the emojis and some of the latex symbols only show as question marks in the REPL.

That's just a font issue with your Terminal.

@mpastell
Copy link
Contributor Author

mpastell commented Mar 3, 2018

True, but that's an issue that exists in the default windows terminal and also in the default Ubuntu terminal (although for less symbols than in windows) and font so it will affect a lot of users.

Also if I hit tab in the terminal and see the character as completion I don't probably remember how to I get the completion without seeing the text. e.g. if I see 👹 and 👺I will probably not remember which one is japanese_goblin and which japanese_ogre

@stevengj
Copy link
Member

stevengj commented Mar 8, 2018

If you are using the REPL in a Terminal where some emoji is not supported by the font, then presumably this PR is irrelevant since you won't be defining variables using that symbol, no?

(Unfortunately, it doesn't seem that we have tab completions for 👹 and 👺. 😛 )

@mpastell
Copy link
Contributor Author

mpastell commented Mar 13, 2018

I suppose you'd avoid the characters that are not supported by the terminal. Another thing is that you'd need to recognize the symbols in the REPL in order to get the completion. So if you type e.g. \a+TAB and see symbols instead of strings you need to remember how type it.

Probably I should just try to find the time to implement this for the REPL and see what people think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants