Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accept-Encoding #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Accept-Encoding #93

wants to merge 1 commit into from

Conversation

lbilli
Copy link

@lbilli lbilli commented Feb 7, 2021

What about adding compression by default?

The empty string "" instructs libcurl to add an Accept-Encoding: header containing all built-in supported encodings.

@codecov-io
Copy link

Codecov Report

Merging #93 (a1461f9) into master (88a217c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   92.94%   92.96%   +0.01%     
==========================================
  Files           5        5              
  Lines         482      483       +1     
==========================================
+ Hits          448      449       +1     
  Misses         34       34              
Impacted Files Coverage Δ
src/Curl/Easy.jl 94.11% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a217c...a1461f9. Read the comment docs.

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Mar 23, 2021

It seems that setting this option not only affects what libcurl advertises as accepting but has the side effect of actually doing the decoding before the data is passed to the caller. That might be good but it's certainly worth considering whether we want to do that. It may also be a breaking change since callers that are setting the Accept-Encoding header already and expecting encoded data will no longer get encoded data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants